Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(points): add stroke to "swap" icon #5630

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

bakoushin
Copy link
Contributor

@bakoushin bakoushin commented Jul 9, 2024

Description

The swap icon lost its stroke compared to one in figma. This fixes it.

Context: https://valora-app.slack.com/archives/C0684TXDR3K/p1720545011018399

Before fix After fix In Figma
image image image

Test plan

Visual assessment

Related issues

Backwards compatibility

Y

Network scalability

NA

@bakoushin bakoushin enabled auto-merge July 9, 2024 21:10
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.70%. Comparing base (7dbe6ee) to head (85c9388).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5630      +/-   ##
==========================================
- Coverage   86.71%   86.70%   -0.01%     
==========================================
  Files         773      773              
  Lines       31567    31567              
  Branches     5456     5456              
==========================================
- Hits        27372    27371       -1     
- Misses       4150     4151       +1     
  Partials       45       45              
Files Coverage Δ
src/icons/SwapArrows.tsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dbe6ee...85c9388. Read the comment docs.

@bakoushin bakoushin added this pull request to the merge queue Jul 10, 2024
Merged via the queue into main with commit be39ab5 Jul 10, 2024
18 checks passed
@bakoushin bakoushin deleted the alex/fix-swap-arrows-icon branch July 10, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants